[UR] Add experimental interface for native enqueue#1645
Merged
callumfare merged 15 commits intooneapi-src:mainfrom Jun 28, 2024
Merged
[UR] Add experimental interface for native enqueue#1645callumfare merged 15 commits intooneapi-src:mainfrom
callumfare merged 15 commits intooneapi-src:mainfrom
Conversation
e4c799f to
7adf24d
Compare
7adf24d to
3760456
Compare
kbenzie
reviewed
May 22, 2024
Contributor
kbenzie
left a comment
There was a problem hiding this comment.
Overall the changes look good, just need to align the naming convention with the rest of the UR API.
pbalcer
reviewed
May 23, 2024
3760456 to
70e0755
Compare
067a507 to
661b571
Compare
e15298c to
3ad0d3c
Compare
38c3ea2 to
8976051
Compare
71b9658 to
cf638e3
Compare
317f963 to
62a3da7
Compare
Contributor
Author
|
Friendly ping @MartinWehking @oneapi-src/unified-runtime-level-zero-write @PietroGhg |
dac757a to
cdd5134
Compare
PietroGhg
approved these changes
Jun 20, 2024
Contributor
PietroGhg
left a comment
There was a problem hiding this comment.
Native CPU LGTM, thank you
pbalcer
approved these changes
Jun 20, 2024
MartinWehking
approved these changes
Jun 20, 2024
Contributor
Author
|
Friendly ping @oneapi-src/unified-runtime-opencl-write @oneapi-src/unified-runtime-level-zero-write this is high priority |
aarongreig
approved these changes
Jun 24, 2024
932bd1d to
5cf6e7b
Compare
5cf6e7b to
92e009a
Compare
added 15 commits
June 27, 2024 15:51
Add initial API spec for experimental native enqueue.
Use ScopedStream to return the same stream during the lifetime of the RAII object. This allows us to create events outside a user submitted func, and submit work within the user submitted func, since the stream given to the user from urQueueGetNativeHandle is guaranteed to be the same stream that we record events on.
All entry points unsupported for now. Add Entry Point to UR interface loaders
Allow some params to be nullptr. Also update docs to add an entry in ur_structure_type_t. And update Native CPU DDI table
In order to manage native memory migration across ur_mem_handle_ts, we need to know which ur_mem_handle_ts are wrapped up in the void * function data.
As is done in oneapi-src#1711, we don't need to wait on events that are not given directly to UR by the user through the phEventWaitList param.
Add urEnqueueNativeCommand impl for HIP adapter. Also cahnge typo 'quard' to 'guard'.
In line with changing from a sync op to async for memory migration across devices in a context.
Check that deps work before and after standard UR enqueue calls.
92e009a to
52a7fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial API + spec for experimental native enqueue.