Skip to content

Comments

[UR] Add experimental interface for native enqueue#1645

Merged
callumfare merged 15 commits intooneapi-src:mainfrom
hdelan:exp-interop-entrypoint
Jun 28, 2024
Merged

[UR] Add experimental interface for native enqueue#1645
callumfare merged 15 commits intooneapi-src:mainfrom
hdelan:exp-interop-entrypoint

Conversation

@hdelan
Copy link
Contributor

@hdelan hdelan commented May 22, 2024

Add initial API + spec for experimental native enqueue.

@hdelan hdelan force-pushed the exp-interop-entrypoint branch from e4c799f to 7adf24d Compare May 22, 2024 09:52
@github-actions github-actions bot added loader Loader related feature/bug common Changes or additions to common utilities specification Changes or additions to the specification experimental Experimental feature additions/changes/specification cuda CUDA adapter specific issues labels May 22, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 7adf24d to 3760456 Compare May 22, 2024 13:20
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good, just need to align the naming convention with the rest of the UR API.

@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 3760456 to 70e0755 Compare May 27, 2024 16:22
@github-actions github-actions bot added the conformance Conformance test suite issues. label May 27, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch 6 times, most recently from 067a507 to 661b571 Compare May 29, 2024 11:11
@github-actions github-actions bot added level-zero L0 adapter specific issues hip HIP adapter specific issues labels May 29, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch 4 times, most recently from e15298c to 3ad0d3c Compare May 31, 2024 09:24
@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 38c3ea2 to 8976051 Compare June 11, 2024 09:34
@github-actions github-actions bot added the native-cpu Native CPU adapter specific issues label Jun 11, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch 2 times, most recently from 71b9658 to cf638e3 Compare June 11, 2024 12:42
@github-actions github-actions bot added the command-buffer Command Buffer feature addition/changes/specification label Jun 11, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch 2 times, most recently from 317f963 to 62a3da7 Compare June 12, 2024 14:23
@hdelan hdelan requested a review from PietroGhg June 18, 2024 10:00
@hdelan
Copy link
Contributor Author

hdelan commented Jun 18, 2024

Friendly ping @MartinWehking @oneapi-src/unified-runtime-level-zero-write @PietroGhg

@hdelan hdelan force-pushed the exp-interop-entrypoint branch from dac757a to cdd5134 Compare June 19, 2024 14:43
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM, thank you

@hdelan
Copy link
Contributor Author

hdelan commented Jun 24, 2024

Friendly ping @oneapi-src/unified-runtime-opencl-write @oneapi-src/unified-runtime-level-zero-write this is high priority

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for level zero

@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 932bd1d to 5cf6e7b Compare June 26, 2024 09:16
@hdelan hdelan added the ready to merge Added to PR's which are ready to merge label Jun 27, 2024
@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 5cf6e7b to 92e009a Compare June 27, 2024 11:16
Hugh Delaney added 15 commits June 27, 2024 15:51
Add initial API spec for experimental native enqueue.
Use ScopedStream to return the same stream during the lifetime of the
RAII object. This allows us to create events outside a user submitted
func, and submit work within the user submitted func, since the stream
given to the user from urQueueGetNativeHandle is guaranteed to be the
same stream that we record events on.
All entry points unsupported for now.

Add Entry Point to UR interface loaders
Allow some params to be nullptr.

Also update docs to add an entry in ur_structure_type_t.

And update Native CPU DDI table
In order to manage native memory migration across ur_mem_handle_ts, we
need to know which ur_mem_handle_ts are wrapped up in the void *
function data.
As is done in oneapi-src#1711, we don't need to wait on events that are not given
directly to UR by the user through the phEventWaitList param.
Add urEnqueueNativeCommand impl for HIP adapter. Also cahnge typo
'quard' to 'guard'.
In line with changing from a sync op to async for memory migration
across devices in a context.
Check that deps work before and after standard UR enqueue calls.
@hdelan hdelan force-pushed the exp-interop-entrypoint branch from 92e009a to 52a7fc6 Compare June 27, 2024 14:51
@callumfare callumfare merged commit c5d3b9d into oneapi-src:main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command-buffer Command Buffer feature addition/changes/specification common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants